New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix reversed query string parameters in code generation #1192

Merged
merged 1 commit into from Oct 2, 2018

Conversation

Projects
None yet
2 participants
@jamesallured
Contributor

jamesallured commented Oct 2, 2018

Closes #1189

Tracked this bug down to be an issue with using util._extend which appears to have stability issues and reversed the order of the attributes in the object created. In the Node docs there is a note about the method being deprecated. I have taken the suggested action of replacing the call with Object.assign. I took the opportunity to change all other occurrences of this method call in the file at the same time.

@jamesallured jamesallured changed the title from Change occurences of deprecated util._extend in code generation to Ob… to Fix reversed query string parameters in code generation Oct 2, 2018

@gschier

gschier approved these changes Oct 2, 2018

Nice one! This is awesome 😄

@gschier gschier merged commit f9a4e33 into getinsomnia:develop Oct 2, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@welcome

This comment has been minimized.

welcome bot commented Oct 2, 2018

Congrats on merging your first pull request! 🎉🎉🎉 You're helping make Insomnia awesome! 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment