New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

filter "parameters method" from swagger imports #1197

Merged
merged 1 commit into from Oct 17, 2018

Conversation

Projects
None yet
2 participants
@beardeddragon5
Contributor

beardeddragon5 commented Oct 3, 2018

In swagger files you can specify parameters for a path.
Insomnia added this parameters as methods. This simply filters this "parameters methods"

Matthias Ramsauer
@welcome

This comment has been minimized.

welcome bot commented Oct 3, 2018

💖 Thanks for opening this pull request! 💖

To help make this a smooth process, please be sure you have first read the
contributing guidelines.

@gschier

This comment has been minimized.

Collaborator

gschier commented Oct 11, 2018

Can you please provide more detail on what this is actually doing? I'm not familiar enough with Swagger to know what this means.

@beardeddragon5

This comment has been minimized.

Contributor

beardeddragon5 commented Oct 12, 2018

In swagger you can write this to add parameters to all methods for a specific path.
At the moment if you import a swagger file the "parameters" will be interpretet as a method.
There might be a lot more wrong if the importer ignores this, but the most annoying are the extra useless requests that get "imported".

paths:
    /test/:
        parameters:
           ...
        get:
@gschier

Looks good, thanks! 😄

@gschier gschier merged commit 971a2b4 into getinsomnia:develop Oct 17, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@welcome

This comment has been minimized.

welcome bot commented Oct 17, 2018

Congrats on merging your first pull request! 🎉🎉🎉 You're helping make Insomnia awesome! 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment