New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Python Requests Code generation #1200

Merged
merged 1 commit into from Oct 11, 2018

Conversation

Projects
None yet
3 participants
@thewheat
Contributor

thewheat commented Oct 6, 2018

Closes #1188

Currently the code generation with Python Requests is missing out query string variables specifed in the URL string

image

New code fixes this and confirm it works with both query strings specified in URL and in query section editor
image

@welcome

This comment has been minimized.

welcome bot commented Oct 6, 2018

💖 Thanks for opening this pull request! 💖

To help make this a smooth process, please be sure you have first read the
contributing guidelines.

@ryanprior

This comment has been minimized.

ryanprior commented Oct 9, 2018

Thanks for this, @thewheat. Nice simple patch 😄

@gschier

Woah, nice catch! 💯

@gschier gschier merged commit 2174a8f into getinsomnia:develop Oct 11, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@welcome

This comment has been minimized.

welcome bot commented Oct 11, 2018

Congrats on merging your first pull request! 🎉🎉🎉 You're helping make Insomnia awesome! 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment