New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix undefined id causing improper import #1302

Merged
merged 1 commit into from Dec 12, 2018

Conversation

Projects
None yet
2 participants
@thewheat
Copy link
Contributor

thewheat commented Dec 12, 2018

Fixes #1257

When endpointSchema.operationId is undefined it causes endpointSchema.operationId + (index > 0 ? index : '') to evaluate to a string of text value undefined

That caused all requests to have the same id and thus new endpoints overwrote an existing one when it shouldn't have

@gschier
Copy link
Collaborator

gschier left a comment

Thanks for fixing this one @thewheat! 😄 👍

@gschier gschier changed the title Fixes #1257: Fix undefined id causing improper import Fix undefined id causing improper import Dec 12, 2018

@gschier gschier merged commit 7bdd408 into getinsomnia:develop Dec 12, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment