Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fetch new access and refresh tokens when refresh fails #1338

Merged
merged 2 commits into from Jan 21, 2019

Conversation

Projects
None yet
2 participants
@rafaelrenanpacheco
Copy link
Contributor

commented Jan 16, 2019

This PR will allow Insomnia to re-authenticate again to get brand new access and refresh tokens when the refresh token request fails due an unauthorized request. This happens when the backend rejects the refresh token for some reason, like refresh token expiration.

This is an opinionated implementation, which means that this behavior is not configurable. @gschier let me know if an option to configure this behavior is necessary.

rafaelrenanpacheco added some commits Jan 16, 2019

@gschier

This comment has been minimized.

Copy link
Collaborator

commented Jan 18, 2019

I haven't taken a look yet but I'm excited for this! Will try and get to it next week.

@gschier
Copy link
Collaborator

left a comment

Awesome, thanks for implementing this! Such a simple solution too.

@gschier gschier merged commit 8112f5d into getinsomnia:develop Jan 21, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@rafaelrenanpacheco rafaelrenanpacheco deleted the rafaelrenanpacheco:oauth2-refresh-retry branch Jan 21, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.