Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Base64url encoding (#1348) #1349

Merged
merged 1 commit into from Mar 13, 2019

Conversation

Projects
None yet
2 participants
@aldaris
Copy link
Contributor

commented Jan 23, 2019

This small and dirty change adds support for Base64url encoding & decoding.

I had only one concern though, when I intentionally broke the test, npm test was still returning successfully, so not really sure what's going on with that...

@welcome

This comment has been minimized.

Copy link

commented Jan 23, 2019

💖 Thanks for opening this pull request! 💖

To help make this a smooth process, please be sure you have first read the
contributing guidelines.

@gschier
Copy link
Collaborator

left a comment

I love this PR! Just one comment 💯

Show resolved Hide resolved plugins/insomnia-plugin-base64/index.js Outdated
@aldaris

This comment has been minimized.

Copy link
Contributor Author

commented Mar 12, 2019

@gschier do you have any tips, why npm test doesn't fail when I intentionally break the tests I've added?

@aldaris

This comment has been minimized.

Copy link
Contributor Author

commented Mar 12, 2019

Never mind, I figured it out.

@aldaris aldaris force-pushed the aldaris:base64url branch from 9bf79f9 to 6221361 Mar 12, 2019

@aldaris

This comment has been minimized.

Copy link
Contributor Author

commented Mar 13, 2019

The review comments have been addressed, let me know if any other changes are needed. Thanks!

@gschier gschier merged commit b6b02eb into getinsomnia:develop Mar 13, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@welcome

This comment has been minimized.

Copy link

commented Mar 13, 2019

Congrats on merging your first pull request! 🎉🎉🎉 You're helping make Insomnia awesome! 🙌

@gschier

This comment has been minimized.

Copy link
Collaborator

commented Mar 13, 2019

Awesome, thanks!

@aldaris aldaris deleted the aldaris:base64url branch Mar 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.