Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add request authentication getter and setter to plugin request context. #1393

Conversation

Projects
None yet
2 participants
@samirnijenhuis
Copy link

commented Mar 2, 2019

This PR enables plugin developers to set and get the authentication configuration of a request.

I built a small plugin that allows me to define my OAuth 2 settings on an environment and automate the authentication for every request I add to my workspace. This way I don't have to look / configure auth settings for every single request.

The following issues could benefit from this pr:
#1116
#790

@welcome

This comment has been minimized.

Copy link

commented Mar 2, 2019

💖 Thanks for opening this pull request! 💖

To help make this a smooth process, please be sure you have first read the
contributing guidelines.

@gschier
Copy link
Collaborator

left a comment

Just a small comment. Looks good otherwise! This will be super useful

Show resolved Hide resolved packages/insomnia-app/app/plugins/context/request.js Outdated
@gschier
Copy link
Collaborator

left a comment

Awesome, thanks for this!

@gschier gschier merged commit 6717135 into getinsomnia:develop Apr 18, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@welcome

This comment has been minimized.

Copy link

commented Apr 18, 2019

Congrats on merging your first pull request! 🎉🎉🎉 You're helping make Insomnia awesome! 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.