Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue #1202. Lenient error handling for Yarn output. Check if out… #1425

Merged
merged 2 commits into from Apr 13, 2019

Conversation

Projects
None yet
2 participants
@senoctar
Copy link
Contributor

commented Apr 3, 2019

As written in #1202 the problem with exit error codes on Windows seems to be in yarn or electron. The root cause is not likely to be solved, it seems to be a reoccurring issue randomly affecting projects. It's probably deep in memory management.

The fix primarily consists of first testing if Yarn standard output is OK (either json or success prompt depending on command) and checking the exit error code only if the standard output test fails.

Fix issue #1202. Lenient error handling for Yarn output. Check if out…
…put is OK even if exit error code is non-zero.
@welcome

This comment has been minimized.

Copy link

commented Apr 3, 2019

💖 Thanks for opening this pull request! 💖

To help make this a smooth process, please be sure you have first read the
contributing guidelines.

@gschier
Copy link
Collaborator

left a comment

I'm okay making this change but, since it's a workaround, there should be some comments explaining what it's doing and why it need to be there.

@senoctar senoctar force-pushed the senoctar:fix_1202 branch from ab5d0a4 to a9260b1 Apr 8, 2019

@senoctar

This comment has been minimized.

Copy link
Contributor Author

commented Apr 8, 2019

PR is updated with explanatory comments on changed code.

@senoctar senoctar force-pushed the senoctar:fix_1202 branch from a9260b1 to 033c086 Apr 9, 2019

@gschier
Copy link
Collaborator

left a comment

Awesome, thanks!

@gschier gschier merged commit aee70d8 into getinsomnia:develop Apr 13, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@welcome

This comment has been minimized.

Copy link

commented Apr 13, 2019

Congrats on merging your first pull request! 🎉🎉🎉 You're helping make Insomnia awesome! 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.