Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve property order in environment editor #1497

Merged
Merged
Changes from 1 commit
Commits
File filter...
Filter file types
Jump to…
Jump to file or symbol
Failed to load files and symbols.

Always

Just for now

Keep property order

  • Loading branch information...
develohpanda committed May 12, 2019
commit 69186800c650ced72bddadebba0d9ef353e2a3af

Some generated files are not rendered by default. Learn more.

@@ -13,7 +13,7 @@ export const canSync = true;
type BaseEnvironment = {
name: string,
data: Object,
propertyMap: Object,
propertyMap: Object | null,
color: string | null,
metaSortKey: number,
sortProperties: boolean,
@@ -28,7 +28,7 @@ export function init() {
return {
name: 'New Environment',
data: {},
propertyMap: {},
propertyMap: null,
This conversation was marked as resolved by develohpanda

This comment has been minimized.

Copy link
@gschier

gschier May 21, 2019

Collaborator

Can we rename this to dataPropertyOrder in order to better signify what it's for?

color: null,
isPrivate: false,
metaSortKey: Date.now(),
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.