Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add iconUrl to electron-builder config so it populates in Control Panel and Windows Settings properly #1514

Merged
merged 1 commit into from May 21, 2019

Conversation

Projects
None yet
2 participants
@banksio
Copy link
Contributor

commented May 21, 2019

Change made due to documentation here.

The Insomnia app currently has no icon in Control Panel for the app:
image
This change gives Insomnia the correct icon in Control Panel and Windows Settings:
image
image
Unfortunately does not solve #1405, this seems to be a bug upstream and since Squirrel.Windows is deprecated, likely will not be fixed, see that issue for discussion.

@welcome

This comment has been minimized.

Copy link

commented May 21, 2019

💖 Thanks for opening this pull request! 💖

To help make this a smooth process, please be sure you have first read the
contributing guidelines.

@gschier
Copy link
Collaborator

left a comment

Dang, that was simple! Now I'm embarrassed that I missed that setting for so long 😆

@gschier gschier merged commit 639d0cc into getinsomnia:develop May 21, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@welcome

This comment has been minimized.

Copy link

commented May 21, 2019

Congrats on merging your first pull request! 🎉🎉🎉 You're helping make Insomnia awesome! 🙌

Thejas007 added a commit to Thejas007/insomnia that referenced this pull request May 24, 2019

Thejas007 added a commit to Thejas007/insomnia that referenced this pull request May 24, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.