Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download path settings per request #1544

Merged

Conversation

@develohpanda
Copy link
Contributor

commented Jun 3, 2019

Closes #1511.

Saves request download path in request-meta instead of request-url-bar state. This allows the setting to be per request rather than global.

Ideally I would expect this downloadPath setting (and others in future) to exist in a 'requestSettings` object in meta and passed around as a whole rather than adding x props for each new setting. I feel that is out of scope for this PR though - thoughts?

Send + download
image

Send only
image

@develohpanda develohpanda changed the title Feature/1511 local request settings Download path settings per request Jun 3, 2019

@gschier

This comment has been minimized.

Copy link
Collaborator

commented Jun 3, 2019

Ideally I would expect this downloadPath setting (and others in future) to exist in a 'requestSettings` object in meta and passed around as a whole rather than adding x props for each new setting. I feel that is out of scope for this PR though - thoughts?

Yes, I agree. It would be nice for the future but out of scope for this PR.

@gschier

gschier approved these changes Jun 3, 2019

Copy link
Collaborator

left a comment

Thanks again @develohpanda! I have nothing to add on this one 😄 👍

@gschier gschier merged commit 5d82a5e into getinsomnia:develop Jun 3, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@develohpanda develohpanda deleted the develohpanda:feature/1511-local-request-settings branch Jun 3, 2019

@dvdbot

This comment has been minimized.

Copy link

commented Jun 4, 2019

Thanks for the pull-request @develohpanda - can't wait to test this out

@develohpanda

This comment has been minimized.

Copy link
Contributor Author

commented Jun 4, 2019

Thanks for the pull-request @develohpanda - can't wait to test this out

No worries mate!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.