Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update HTTP Status Code Descriptions #1554

Merged
merged 5 commits into from Jun 10, 2019

Conversation

@nwthomas
Copy link
Contributor

commented Jun 8, 2019

Closes #1553

As per the issue description, I spotted some minor sentence flow and grammatical issues in the HTTP status codes while using Insomnia. They're mostly in the 400 range, but I tweaked a few others as well.

One file has been changed, constants.js. Everything checks out locally. 馃嵕馃帀馃帄

Thanks for making an amazing tool like Insomnia.

@welcome

This comment has been minimized.

Copy link

commented Jun 8, 2019

馃挅 Thanks for opening this pull request! 馃挅

To help make this a smooth process, please be sure you have first read the
contributing guidelines.

nwthomas added some commits Jun 8, 2019

@gschier

This comment has been minimized.

Copy link
Collaborator

commented Jun 10, 2019

Thank you for the fixes @nwthomas! I will merge them in but I would like to point out that these descriptions are sourced from here: https://developer.mozilla.org/en-US/docs/Web/HTTP/Status

Perhaps there is a way that you can also contribute these improvements back to the MDN docs?

@gschier gschier merged commit a7ac4c1 into getinsomnia:develop Jun 10, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@welcome

This comment has been minimized.

Copy link

commented Jun 10, 2019

Congrats on merging your first pull request! 馃帀馃帀馃帀 You're helping make Insomnia awesome! 馃檶

@nwthomas

This comment has been minimized.

Copy link
Contributor Author

commented Jun 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can鈥檛 perform that action at this time.