Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix file not being selected on content-type change #1584

Conversation

@brendano86
Copy link

commented Jul 2, 2019

Fix race condition on setting request body and headers to ensure the file is selected after content-type change

Closes #1542

@welcome

This comment has been minimized.

Copy link

commented Jul 2, 2019

💖 Thanks for opening this pull request! 💖

To help make this a smooth process, please be sure you have first read the
contributing guidelines.

@brendano86

This comment has been minimized.

Copy link
Author

commented Jul 15, 2019

@gschier thoughts?

@gschier

gschier approved these changes Aug 5, 2019

Copy link
Collaborator

left a comment

Sorry for the delay! This looks great, thanks for taking the time to figure out the fix 🤗💯

@gschier gschier merged commit f836913 into getinsomnia:develop Aug 5, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@welcome

This comment has been minimized.

Copy link

commented Aug 5, 2019

Congrats on merging your first pull request! 🎉🎉🎉 You're helping make Insomnia awesome! 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.