Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[network] Use system CA on Linux #1587

Open
wants to merge 1 commit into
base: develop
from

Conversation

Projects
None yet
2 participants
@captn3m0
Copy link

commented Jul 6, 2019

@welcome

This comment has been minimized.

Copy link

commented Jul 6, 2019

💖 Thanks for opening this pull request! 💖

To help make this a smooth process, please be sure you have first read the
contributing guidelines.

@gschier
Copy link
Collaborator

left a comment

Thanks for the PR! Just one comment 👍

@@ -353,7 +354,11 @@ export async function _actuallySend(

// Setup CA Root Certificates if not on Mac. Thanks to libcurl, Mac will use
// certificates form the OS.
if (process.platform !== 'darwin') {
if (process.platform === 'linux') {
const fullCAPath = certFinder.findCABundle();

This comment has been minimized.

Copy link
@gschier

gschier Jul 15, 2019

Collaborator

Will we still need to fallback to the bundled CAs if findCABundle does not return a value?

This comment has been minimized.

Copy link
@captn3m0

captn3m0 Jul 15, 2019

Author

I think this should work across all desktop linux distros, but I can re-route to force the local cert as a fallback.

Can you point me to the debian/span recipes? Want to ensure that ca-certificates is installed in both of these, and the cert-finder works.

This comment has been minimized.

Copy link
@gschier

gschier Jul 15, 2019

Collaborator

Can you explain what you mean by recipes?

@gschier

This comment has been minimized.

Copy link
Collaborator

commented Jul 15, 2019

Oh, and for the tests, you just need to add a Flow definition for the new module in /packages/insomnia-app/flow-typed/

@captn3m0

This comment has been minimized.

Copy link
Author

commented Jul 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.