Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audience parameter for Resource Owner Password Credentials #1677

Merged
merged 1 commit into from Sep 17, 2019

Conversation

@CodyDWJones
Copy link
Contributor

commented Sep 14, 2019

Closes #1676

@welcome

This comment has been minimized.

Copy link

commented Sep 14, 2019

💖 Thanks for opening this pull request! 💖

To help make this a smooth process, please be sure you have first read the
contributing guidelines.

@CodyDWJones CodyDWJones force-pushed the CodyDWJones:master branch from ccabeda to b5c7f4e Sep 14, 2019
Copy link
Collaborator

left a comment

Awesome stuff. Thanks for getting this one done! 🥳

@@ -12,6 +12,7 @@ const CLIENT_SECRET = 'secret_12345456677756343';
const USERNAME = 'user';
const PASSWORD = 'password';
const SCOPE = 'scope_123';
const AUDIENCE = 'https://foo.com/userinfo';

This comment has been minimized.

Copy link
@gschier

gschier Sep 17, 2019

Collaborator

Nice! Thanks for updating the tests too 😄

@@ -433,7 +433,7 @@ class OAuth2Auth extends React.PureComponent<Props, State> {
} else if (grantType === GRANT_TYPE_PASSWORD) {
basicFields = [username, password, accessTokenUrl, clientId, clientSecret, enabled];

advancedFields = [scope, credentialsInBody, tokenPrefix];
advancedFields = [scope, credentialsInBody, tokenPrefix, audience];

This comment has been minimized.

Copy link
@gschier

gschier Sep 17, 2019

Collaborator

Nice, that was a simple modification 💯

@gschier gschier merged commit d2d29bd into getinsomnia:master Sep 17, 2019
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@welcome

This comment has been minimized.

Copy link

commented Sep 17, 2019

Congrats on merging your first pull request! 🎉🎉🎉 You're helping make Insomnia awesome! 🙌

TeeSeal added a commit to TeeSeal/insomnia that referenced this pull request Oct 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.