Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Escape dirs in the yarn cmd #1688

Merged
merged 1 commit into from Sep 30, 2019

Conversation

@v1ktor
Copy link
Contributor

commented Sep 27, 2019

Fixes #1355

The yarn doesn't understand spaces in path, so they have to be escaped.

@welcome

This comment has been minimized.

Copy link

commented Sep 27, 2019

💖 Thanks for opening this pull request! 💖

To help make this a smooth process, please be sure you have first read the
contributing guidelines.

@v1ktor v1ktor changed the title Escape dirs in the yarn cmd #1355 Escape dirs in the yarn cmd Sep 27, 2019
Copy link
Collaborator

left a comment

Nice catch! That probably explains some of the intermittent plugin install problems people have been reporting.

@gschier gschier merged commit e1c185c into getinsomnia:develop Sep 30, 2019
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@welcome

This comment has been minimized.

Copy link

commented Sep 30, 2019

Congrats on merging your first pull request! 🎉🎉🎉 You're helping make Insomnia awesome! 🙌

@v1ktor

This comment has been minimized.

Copy link
Contributor Author

commented Oct 3, 2019

I have downloaded 7.0.0 update today and unfortunately It didn't fully fix the issue on windows. The _getYarnPath() also should be escaped, but I have missed that since yarn-standalone was installed in the path without space on my local env :(

I will verify and do another PR soon.

@v1ktor v1ktor deleted the v1ktor:issue/1355 branch Oct 3, 2019
@v1ktor v1ktor referenced this pull request Oct 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.