Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix transparent line-numbers background #1690

Merged
merged 1 commit into from Sep 30, 2019

Conversation

@ranjan-purbey
Copy link
Contributor

commented Sep 28, 2019

Closes #1647

@welcome

This comment has been minimized.

Copy link

commented Sep 28, 2019

💖 Thanks for opening this pull request! 💖

To help make this a smooth process, please be sure you have first read the
contributing guidelines.

Copy link

left a comment

Would be nice to have 80% opacity applied to the background:
https://stackoverflow.com/questions/12771102/modify-alpha-opacity-of-less-variable

@ranjan-purbey

This comment has been minimized.

Copy link
Contributor Author

commented Sep 29, 2019

I know, but the thing is background color is stored in a CSS3 variable and not a less variable. So the fade function won't work, and CSS by itself doesn't provide a way to achieve this. Is there any specific reason to add transparency?

@arbitrary-dev

This comment has been minimized.

Copy link

commented Sep 29, 2019

Just for coolness)

Isn't there a way to assign CSS3 variable to some temporary LESS variable and then apply fade() on it?

@ranjan-purbey

This comment has been minimized.

Copy link
Contributor Author

commented Sep 30, 2019

No, that can't be done

Copy link
Collaborator

left a comment

Thanks for this fix! Looks great 😄

@gschier gschier merged commit e14237a into getinsomnia:develop Sep 30, 2019
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@welcome

This comment has been minimized.

Copy link

commented Sep 30, 2019

Congrats on merging your first pull request! 🎉🎉🎉 You're helping make Insomnia awesome! 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.