Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Escape yarn paths #1699

Merged
merged 1 commit into from Oct 7, 2019

Conversation

@v1ktor
Copy link
Contributor

commented Oct 3, 2019

Additional fix to PR #1688

I have downloaded 7.0.0 update today and unfortunately It didn't fully fix the issue on windows. The _getYarnPath() also should be escaped, but I have missed that since yarn-standalone was installed in the path without space on my local env :(

I have added spaces locally to plugin and yarn folders and now it works
electron_2019-10-03_16-08-07

@gschier
gschier approved these changes Oct 7, 2019
Copy link
Collaborator

left a comment

Good catch 👍

@gschier gschier merged commit 9909f8e into getinsomnia:develop Oct 7, 2019
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.