Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No longer override `extraKeys` in CodeMirror on initialization #1701

Merged
merged 1 commit into from Oct 7, 2019

Conversation

@malwilley
Copy link
Contributor

commented Oct 4, 2019

Fixes #1694

Problem here was that extraKeys got overridden on initialization. Made sure to include the base options in the override. Comment toggling and other custom hotkeys should now work again in the editor.

@malwilley malwilley changed the title No longer override in GraphQL editor on initialization No longer override `extraKeys` in GraphQL editor on initialization Oct 4, 2019
@malwilley malwilley changed the title No longer override `extraKeys` in GraphQL editor on initialization No longer override `extraKeys` in CodeMirror on initialization Oct 4, 2019
@gschier
gschier approved these changes Oct 7, 2019
Copy link
Collaborator

left a comment

Oooo, nice catch on this one 😄

@gschier gschier merged commit 552ca2a into getinsomnia:develop Oct 7, 2019
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.