New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always show request timer with one decimal precision #617

Merged
merged 1 commit into from Nov 22, 2017

Conversation

Projects
None yet
2 participants
@k-nut
Contributor

k-nut commented Nov 22, 2017

I was slightly bothered by the request timer jumping because it was reducing its precision when it reached .0. I therefore propose to always call toFixed(1) on it for a nicer look.

Before

bad

After

good

@gschier

Beautiful! That's much better.

@gschier gschier merged commit 1173001 into getinsomnia:develop Nov 22, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@k-nut

This comment has been minimized.

Contributor

k-nut commented Nov 22, 2017

Thank you, this was super quick! 🚀

@k-nut k-nut deleted the k-nut:timer-same-precision branch Nov 22, 2017

@gschier

This comment has been minimized.

Collaborator

gschier commented Nov 22, 2017

No problem. Thank you! Your patch will appear in the next release, hopefully by the end of the week. Congrats on your first contribution 👍 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment