Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
UI for filter requests by folder, URI, method, query string #864
#797 - I previously implemented some of the logic to allow searching by folder, URI, and query string here, but nothing was apparent in the UI.
What does this PR do?
Example screenshots, gifs, or videos?
What is left to do or discuss?
What code can others reuse?
referenced this pull request
Apr 15, 2018
I think you made the right move by not adding method/uri/querystring filtering to the sidedbar. The highlight component would be a great addition if you wanted to add that
Ya, pulling those out into a class would be
Seems like this is because we're first splitting the search phrase into terms and fuzzysorting each of them one-by one. Maybe we can just pass the whole string to fuzzysort instead?
I have the sidebar showing highlights of the filters now, including the query and the folders.
Here is a preview of sidebar searching:
I still need to address the other issues I mentioned. I'm probably out for the day but hopefully can handle this week.