New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Traversing further into scope directories #914

merged 3 commits into from May 23, 2018


None yet
3 participants

skang0601 commented May 2, 2018

Related #912

Just a little tweak to recursive traverse into the scop directories. I'm pretty unfamiliar with modern JS development so let me know if I'm doing anything egregious.

I've also noticed that the tests related to the AWS auth headers are failing locally, not sure why that's the case.


This comment has been minimized.

welcome bot commented May 2, 2018

💖 Thanks for opening this pull request! 💖

To help make this a smooth process, please be sure you have first read the
contributing guidelines.

@skang0601 skang0601 force-pushed the skang0601:feature/scope-npm-plugins branch from 4fa6ba2 to 9da9721 May 2, 2018

gschier and others added some commits May 3, 2018


Looks great! Thanks @skang0601

@gschier gschier merged commit 8fdd22d into getinsomnia:develop May 23, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
continuous-integration/travis-ci/pr The Travis CI build passed

This comment has been minimized.

welcome bot commented May 23, 2018

Congrats on merging your first pull request! 🎉🎉🎉 You're helping make Insomnia awesome! 🙌


This comment has been minimized.


gschier commented May 23, 2018

FYI, those tests were fixed in a later commit 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment