Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert `dump()` helper to a core component #339

Closed
bastianallgeier opened this issue Jul 1, 2019 · 2 comments

Comments

@bastianallgeier
Copy link
Contributor

@bastianallgeier bastianallgeier commented Jul 1, 2019

This would add the option to create your own dumper plugin with Symfony's dumper for example.

See: getkirby/kirby#1881

@bastianallgeier bastianallgeier added this to Backlog in Roadmap via automation Jul 1, 2019
@bastianallgeier bastianallgeier moved this from Backlog to Low-hanging fruits in Roadmap Jul 1, 2019
@bastianallgeier

This comment has been minimized.

Copy link
Contributor Author

@bastianallgeier bastianallgeier commented Oct 15, 2019

will be in 3.3.0

Roadmap automation moved this from Low-hanging fruits to Done Oct 15, 2019
@lemmon

This comment has been minimized.

Copy link

@lemmon lemmon commented Nov 6, 2019

Still does not work for me when using Kirby with Composer. Seems that composer autoloads var-dumper first where the dump() function is declared (https://github.com/symfony/var-dumper/blob/v4.3.6/composer.json#L39). Only after that is Kirby being loaded and tries to re-declare the dump function again, hence the fatal error.

I still believe that the kirby's dump function should be checked for existing duplicate before declaring. @bastianallgeier Or am I doing something wrong? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Roadmap
  
Done
2 participants
You can’t perform that action at this time.