From 5cb269887afd2570aa695de59b7a2a86b65c51f0 Mon Sep 17 00:00:00 2001 From: Nico Hoffmann Date: Sat, 1 Jun 2024 23:14:34 +0200 Subject: [PATCH 1/4] Update PR template --- .github/PULL_REQUEST_TEMPLATE.md | 16 +++++++++++----- 1 file changed, 11 insertions(+), 5 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 2dc6ecaad6..78a0927adb 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -6,11 +6,19 @@ Use this section for review hints, explanations or discussion points/todos. Make sure to point your PR to the relevant develop branches, e.g. `develop-patch`, `develop-minor` or `v5/develop` +How to contribute: https://contribute.getkirby.com +--> + +### What has changed? + +### Why was it changed? + + +## Changelog + ### Fixes @@ -23,7 +31,7 @@ How to contribute: https://contribute.getkirby.com ## Docs @@ -32,8 +40,6 @@ to be your best writing, just a few words and/or code snipptets. - [ ] In-code documentation (wherever needed) From 1fac746550f5a4364e82b2eca24db42a0ce26cec Mon Sep 17 00:00:00 2001 From: Lukas Bestle Date: Sun, 2 Jun 2024 09:29:59 +0200 Subject: [PATCH 2/4] Additional updates --- .github/PULL_REQUEST_TEMPLATE.md | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 78a0927adb..89a7e9bbd4 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -1,4 +1,4 @@ -## This PR … +## Description -### What has changed? +### This PR changes… -### Why was it changed? +### Reason -### What should reviewers know? +### For reviewers @@ -52,7 +52,7 @@ If not, don't worry - we will take care of it. - [ ] In-code documentation (wherever needed) - [ ] Unit tests for fixed bug/feature -- [ ] Tests and checks all pass +- [ ] Tests and CI checks all pass ### For review team -### This PR changes… +### Summary of changes -### Reason +### Reasoning -### For reviewers +### Additional context