Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Panel] Date Field "Today" Button Doesn't Actually Set Date/Time To Now #1736

Closed
neildaniels opened this issue May 2, 2019 · 5 comments

Comments

@neildaniels
Copy link
Contributor

commented May 2, 2019

Describe the bug
When clicking on the "Today" button in a date field calendar, I fully expected the value in the field to be changed to today (or now, if using a time field as well).

Is this intentional? I can't really seem to think of a compelling use case for wanting this behavior.

To Reproduce
Steps to reproduce the behavior:

  1. Open a date picker on a panel page
  2. Select some date a couple months from now
  3. Open up the calendar picker and click "Today"

Expected behavior
I would expect the calendar view and value to be set to today. Instead, it currently just changes the calendar view to focus on this month.

Screenshots
Screen Shot 2019-05-02 at 12 47 43 PM

Kirby Version
3.1.3

Desktop (please complete the following information):

  • OS: macOS 10.14.4 (18E226)
  • Chrome 74.0.3729.131
  • Safari 12.1 (14607.1.40.1.4)
@distantnative

This comment has been minimized.

Copy link
Contributor

commented May 3, 2019

I think this is a similar discussion as the month arrows: does navigating (in this case today navigates you back to the current month/day) in the calendar dropdown directly updates the field value. Or do you need to click explicitly no the day for that... While with the arrows I was convinced that the current implementation is correct, with this one I am much more torn.

@distantnative distantnative added this to the 3.2.3 milestone Jun 2, 2019
@bastianallgeier bastianallgeier modified the milestones: 3.2.3, 3.2.4 Jul 10, 2019
@distantnative distantnative modified the milestones: 3.2.4, 3.3.0 Aug 2, 2019
@distantnative

This comment has been minimized.

Copy link
Contributor

commented Aug 2, 2019

Pushing this to 3.3.0 as I feel this will give us bit more breathing room to think about the date field in general.

@moritzebeling

This comment has been minimized.

Copy link

commented Aug 21, 2019

I would think: When clicking on Today, the user is not moving the timeframe to select from, but instead is already deciding for one single day. Consequently the field should react in the same way, just as one would have clicked on one of the other days (field gets filled, calendar disappears).

If the other reaction feels more natural, the button should be called Show current month.

@distantnative

This comment has been minimized.

Copy link
Contributor

commented Aug 21, 2019

When clicking on Today, the user is not moving the timeframe to select from, but instead is already deciding for one single day.

We have heard very different perspectives on this. It isn't as clear cut as you put it. Some do as you describe, some do as it is implemented right now.

However, I actually like the suggestion to just rename it to "Current month" which avoids communicating differing expectations.

distantnative added a commit that referenced this issue Sep 13, 2019
@distantnative distantnative modified the milestones: 3.3.0, 3.2.5 Sep 13, 2019
@distantnative distantnative self-assigned this Sep 13, 2019
distantnative added a commit that referenced this issue Sep 14, 2019
distantnative added a commit that referenced this issue Sep 15, 2019
bastianallgeier added a commit that referenced this issue Sep 17, 2019
@bastianallgeier

This comment has been minimized.

Copy link
Contributor

commented Sep 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
You can’t perform that action at this time.