Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw exception for multiple default languages #1849

Closed
bnomei opened this issue Jun 11, 2019 · 2 comments

Comments

@bnomei
Copy link

commented Jun 11, 2019

since i copy and pasted a language definition file and forgot to unset the default value i had two default languages in the language settings page. maybe did not cause any problems, but i was wondering what other parts of the kirby core or panel might do if there are two default languages. will it break? will only one be used? which one?

kirby 3.1.4

@distantnative

This comment has been minimized.

Copy link
Contributor

commented Jun 12, 2019

As you described how it happened, it's hard to prevent. I can't say from the top of my head which language would be treated as default in this case.

In my opinion, we should have a check for that in the core (multiple defaults) and throw a fatal error, so that developers/users are aware of the situation and can change it manually.

@bastianallgeier bastianallgeier modified the milestones: 3.2.3, 3.2.4 Jul 10, 2019

@distantnative distantnative self-assigned this Aug 2, 2019

@distantnative distantnative changed the title multiple default languages possible Throw exception for multiple default languages Aug 2, 2019

distantnative added a commit that referenced this issue Aug 2, 2019
distantnative added a commit that referenced this issue Aug 8, 2019
bastianallgeier added a commit that referenced this issue Aug 8, 2019
@bastianallgeier

This comment has been minimized.

Copy link
Contributor

commented Aug 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.