Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multiple drop images in textarea results only in one tag #1850

Closed
bnomei opened this issue Jun 11, 2019 · 7 comments

Comments

@bnomei
Copy link

commented Jun 11, 2019

when dropping multiple images from finder into an textare they get uploaded into the files file of the blueprint correctly. however only a single kirbytag for the first image (sorted by name) is created. intended behavior or not?

kirby 3.1.4

@distantnative

This comment has been minimized.

Copy link
Contributor

commented Jun 11, 2019

What would be the expected behavior - multiple Kirbytags (one for each) with/without line breaks?

@bnomei

This comment has been minimized.

Copy link
Author

commented Jun 12, 2019

i expected multiple kirby tags. with linebreaks to reflect the fact that images are wrapped in figure elements which are block elements by default.

@distantnative distantnative added this to the 3.2.2 milestone Jun 12, 2019

@bastianallgeier bastianallgeier modified the milestones: 3.2.2, 3.2.3 Jul 10, 2019

@distantnative

This comment has been minimized.

Copy link
Contributor

commented Jul 19, 2019

@distantnative

This comment has been minimized.

Copy link
Contributor

commented Jul 19, 2019

@bnomei

This comment has been minimized.

Copy link
Author

commented Jul 19, 2019

thanks @distantnative for the related code. i still do not understand why its limited to one file.

@distantnative

This comment has been minimized.

Copy link
Contributor

commented Jul 19, 2019

Wasn't meant as an explanation - just pointers for me to also keep track of where this happens. @bastianallgeier implemented it, so if there wa a reasoning only he knows atm.

@bastianallgeier bastianallgeier modified the milestones: 3.2.3, 3.2.4 Jul 30, 2019

@distantnative distantnative self-assigned this Aug 9, 2019

distantnative added a commit that referenced this issue Aug 9, 2019
bastianallgeier added a commit that referenced this issue Aug 9, 2019
@bastianallgeier

This comment has been minimized.

Copy link
Contributor

commented Aug 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
You can’t perform that action at this time.