Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete Confirmation Dialog Does Not Clear Text Field on Cancel #1858

Closed
neildaniels opened this issue Jun 11, 2019 · 2 comments

Comments

@neildaniels
Copy link
Contributor

commented Jun 11, 2019

Describe the bug
If you attempt to delete a page that has subpages via the "…" button on a pages section, type something in the box, then click "Cancel" the text you entered will still be there if you try to delete the same page or even a different page later on.

To Reproduce
Steps to reproduce the behavior:

  1. Go to somewhere in the Panel with a pages section
  2. Click on '…' next to a page with subpages
  3. Click Delete
  4. Type something in the text field
  5. Click Cancel
  6. Attempt to delete a different page with subpages

Expected behavior
Text field should be empty, instead it currently keeps old text.

Screenshots
Screen Shot 2019-06-11 at 12 57 02 PM

Kirby Version
3.1.4 and 3.2.0-rc.2

Desktop (please complete the following information):

  • OS: macOS 10.14.5 (18F132)
  • Safari 12.1.1 (14607.2.6.1.1)

@neildaniels neildaniels changed the title Delete Confirmation Dialog Does Not Clear "Confirmation" Text Field on Cancel Delete Confirmation Dialog Does Not Clear Text Field on Cancel Jun 11, 2019

@distantnative distantnative added this to the 3.2.1 milestone Jun 12, 2019

@distantnative distantnative self-assigned this Jun 14, 2019

distantnative added a commit that referenced this issue Jun 14, 2019

@zvaehn

This comment has been minimized.

Copy link

commented Jun 24, 2019

it's also not cleared when you delete multiple parent pages at once without a page reload ;)

Screenshot 2019-06-24 at 14 01 16

bastianallgeier added a commit that referenced this issue Jul 1, 2019

@bastianallgeier

This comment has been minimized.

Copy link
Contributor

commented Jul 1, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.