Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Panel] A non-admin user cannot change the role of another user of the same or different role #1919

Closed
texnixe opened this issue Jul 14, 2019 · 1 comment

Comments

@texnixe
Copy link
Contributor

commented Jul 14, 2019

Describe the bug
If I create for example an Editor user (with no permission settings set or with explicit settings to allow changing roles), I get an error message when trying to change the role of another user of the same or a different (non-admin) role. But the option is nevertheless available via the context menu.

You are not allowed to change the role for the user "test@user.com"

title: Editor

options:
  changeRole:
    editor: true
    manager: true
permissions:
  users:
    changeRole: true

To Reproduce
Steps to reproduce the behavior:

  1. Create an Editor blueprint like the above or empty
  2. Create other users with the same or a different non-admin role
  3. Try to change the role of these users via the context menu or in the user view. The change role dialog pops up (even with the option to change to the admin role which should not be the case, but that is another issue).
  4. See error message

Expected behavior
A non-admin user role should still be able to change other users roles (apart from creating admins) if it is allowed via the role blueprint (assuming if there are no settings that everything is allowed).

Screenshots
If applicable, add screenshots to help explain your problem.

Kirby Version
3.2.2

Additional context
I think the user permissions are a bit messed up in general atm.

#1917

@texnixe texnixe changed the title A non-admin user cannot change the role of another user of the same or different role [Panel] A non-admin user cannot change the role of another user of the same or different role Jul 16, 2019
@distantnative distantnative added this to the 3.2.4 milestone Jul 18, 2019
@bastianallgeier bastianallgeier removed this from the 3.2.4 milestone Aug 22, 2019
@distantnative distantnative self-assigned this Sep 14, 2019
distantnative added a commit that referenced this issue Sep 14, 2019
@distantnative distantnative added this to the 3.2.5 milestone Sep 14, 2019
distantnative added a commit that referenced this issue Sep 14, 2019
distantnative added a commit that referenced this issue Sep 14, 2019
distantnative added a commit that referenced this issue Sep 15, 2019
bastianallgeier added a commit that referenced this issue Sep 16, 2019
Allow changeRole for non-admin users #1919
@bastianallgeier

This comment has been minimized.

Copy link
Contributor

commented Sep 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
You can’t perform that action at this time.