Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default Panel language not respected in language selector on install screen/user create dialog #1940

Closed
texnixe opened this issue Jul 22, 2019 · 10 comments

Comments

@texnixe
Copy link
Contributor

commented Jul 22, 2019

Describe the bug
When the default Panel language via the config is set to anything but English in the config like this

return [
    'panel' => [
      'language' => 'de'
    ]
];

this setting should be reflected in the preselected language select on the installation screen as well as in the user create dialog. Currently English is always the preselected language.

To Reproduce
Steps to reproduce the behavior:

  1. Set Panel language to a language other than English in the config
  2. Visit the Panel installation screen (before new users are created)
  3. See English preselected in language select field.
  4. Alternatively, if there are already accounts, create a new user.

Expected behavior
The config Panel language should be respected when creating users.

Screenshots
Bildschirmfoto 2019-07-22 um 13 29 17

Kirby Version
Tested with 3.2.2 but I guess it's not a new issue.

@distantnative distantnative added this to the 3.2.5 milestone Sep 14, 2019
@distantnative distantnative self-assigned this Sep 14, 2019
distantnative added a commit that referenced this issue Sep 14, 2019
distantnative added a commit that referenced this issue Sep 14, 2019
distantnative added a commit that referenced this issue Sep 15, 2019
bastianallgeier added a commit that referenced this issue Sep 16, 2019
Panel default lang on install and user creat #1940
@bastianallgeier

This comment has been minimized.

Copy link
Contributor

commented Sep 16, 2019

@afbora

This comment has been minimized.

Copy link
Contributor

commented Sep 17, 2019

FireShot Capture 760 - Installation - Mægazi_ - http___localhost_test_kirby_3 2 5_panel_installation

Language required but not selected. This is normal?
I expected as selected english, If no setting default panel language.

@distantnative distantnative reopened this Sep 17, 2019
@distantnative

This comment has been minimized.

Copy link
Contributor

commented Sep 17, 2019

That's weird.

For me, when I have set a default language in config, it is preselected correctly and there is no empty option (the one with the dashes present.

Screen Shot 2019-09-17 at 18 57 16

Screen Shot 2019-09-17 at 18 57 23

When I remove the config, the same only that English is preselected.

@afbora

This comment has been minimized.

Copy link
Contributor

commented Sep 17, 2019

Hmm try to access /panel not /panel/installation without setting

@distantnative

This comment has been minimized.

Copy link
Contributor

commented Sep 17, 2019

Oh wow, that shouldn't make a difference 🤯

@afbora

This comment has been minimized.

Copy link
Contributor

commented Sep 17, 2019

I realized that doesn't work even if default panel language defined when accessing /panel address

@distantnative

This comment has been minimized.

Copy link
Contributor

commented Sep 18, 2019

Yea, the problem does not seem to be the change per se, but rather that some Vuex calls (or watchers) aren't activated the same way.

bastianallgeier added a commit that referenced this issue Sep 18, 2019
@bastianallgeier

This comment has been minimized.

Copy link
Contributor

commented Sep 18, 2019

It was pretty simple to fix. The watched translation prop needed to be evaluated immediately when the component is created.

@afbora

This comment has been minimized.

Copy link
Contributor

commented Sep 18, 2019

We made corrections to the RC. Can you render the source files so we can test them again?

@bastianallgeier

This comment has been minimized.

Copy link
Contributor

commented Sep 18, 2019

@afbora I will release a new RC with new dist files in a few minutes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.