Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Files Section "Replace" Menu Item Broken in Safari #1951

Closed
neildaniels opened this issue Jul 26, 2019 · 6 comments

Comments

@neildaniels
Copy link
Contributor

@neildaniels neildaniels commented Jul 26, 2019

Describe the bug
Within a Files section, if you use the context menu on a file, you cannot replace a file in Safari. Works fine in Chrome. You click it and nothing happens.

Screenshots
2019-07-26 at 3 33 PM

Kirby Version
3.2.2

Console output
None

Desktop (please complete the following information):

  • OS: macOS 10.15 Beta (19A512f)
  • Browser: Safari 13.0 (15608.1.34.1.1)

Additional context
Add any other context about the problem here.

@luxlogica

This comment has been minimized.

Copy link

@luxlogica luxlogica commented Jul 26, 2019

Does not seem to work in Firefox, either.

@bastianallgeier bastianallgeier added this to the 3.2.4 milestone Jul 30, 2019
@bastianallgeier

This comment has been minimized.

Copy link
Contributor

@bastianallgeier bastianallgeier commented Aug 9, 2019

Ughhhh. This is the kind of bug that takes much more time than expected :( Firefox and Safari block the input from being clicked here and I don't really understand why. It works as expected in all other places.

@neildaniels

This comment has been minimized.

Copy link
Contributor Author

@neildaniels neildaniels commented Aug 9, 2019

I did some testing on prior versions. This functionality worked fine (at least in Safari) in 3.0.0, 3.1.0, and 3.1.4.

3.2.0 was the first version where this regression occurred, so the breaking change is probably in one of those commits.

@neildaniels

This comment has been minimized.

Copy link
Contributor Author

@neildaniels neildaniels commented Aug 14, 2019

Also seems like the "Open" menu item is broken.

@bastianallgeier

This comment has been minimized.

Copy link
Contributor

@bastianallgeier bastianallgeier commented Sep 30, 2019

@neildaniels I finally found the reason for this. We had an additional API call since 3.2.0, which was called before each action was executed. Safari and Firefox have built-in security features for opening windows and file inputs and they get blocked when there are too many nested JS functions involved to execute the event.

My PR is still in the review process, but we will definitely have the fix in 3.3.0

@bastianallgeier

This comment has been minimized.

Copy link
Contributor

@bastianallgeier bastianallgeier commented Oct 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.