Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Content locking stalling local dev server #2000

Closed
lukaskleinschmidt opened this issue Aug 12, 2019 · 3 comments

Comments

@lukaskleinschmidt
Copy link
Contributor

commented Aug 12, 2019

Describe the bug
For testing purposes I had a lot of panel tabs open and the sheer amount of lock requests was stalling my local dev server.

In a test on my machine I had around 15 panel tabs open. At this time the response time was around 3-5s. After closing all tabs (red line) except one the response time dropped to around 400-500ms.

62860120-71984e00-bcff-11e9-8740-eb4082fd29c1
Since this is probably just an edge case in local development a simple config setting could suffice to disable the locking mechanism.

Another idea would be to make use of the visibility api to enable or disable the lock polling depending on the tab visibility. But this could potentially cause other issues.

Kirby Version
3.2.2

Desktop

  • Windows 10
  • Local PHP Server
  • Firefox
@bastianallgeier

This comment has been minimized.

Copy link
Contributor

commented Sep 3, 2019

@afbora

This comment has been minimized.

Copy link
Contributor

commented Sep 17, 2019

I get error about content locking while change the page slug:

image

code: 500
details: []
exception: "Error"
file: "/test/kirby/3.2.5/kirby/src/Cms/PageActions.php"
key: null
line: 103
message: "Call to a member function remove() on null"
route: "pages/([a-zA-Z0-9.-_%= +@()]+)/slug"
status: "error"
proto: Object

https://github.com/getkirby/kirby/blob/3.2.5-rc.1/src/Cms/PageActions.php#L103

Also we need check out:
https://github.com/getkirby/kirby/blob/3.2.5-rc.1/src/Cms/FileActions.php#L55
https://github.com/getkirby/kirby/blob/3.2.5-rc.1/src/Cms/FileActions.php#L218

@distantnative

This comment has been minimized.

Copy link
Contributor

commented Sep 18, 2019

@afbora Can you create a new issue for that. I think it's not directly related. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.