Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to define smartypants on a per language basis missing? #2037

Closed
texnixe opened this issue Aug 25, 2019 · 1 comment

Comments

@texnixe
Copy link
Contributor

@texnixe texnixe commented Aug 25, 2019

Describe the bug
I would have expected that it is possible to set smartypants on a per language basis in the language configuration files:

<?php

return [
    'code' => 'de',
    'default' => false,
    'direction' => 'ltr',
    'locale' => [
        'de_DE'
    ],
    'name' => 'Deutsch',
    'translations' => [

    ],
    'url' => NULL,
    'smartypants' => [
        'doublequote.open' => "start",
        'doublequote.close' => 'stop',
    ],
];

But this doesn't have any effect, it only works when configuring smartypants in the config, but then obviously without language specific settings.

Expected behavior
It should be possible to define language-specific smartypants options. Wrong syntax or not possible. Studying the source code it looks as if this feature is not implemented.

Kirby Version
Tested with 3.2.3

@distantnative distantnative added this to the 3.3.0 milestone Sep 11, 2019
afbora added a commit that referenced this issue Oct 1, 2019
Closes #2037
@afbora afbora referenced this issue Oct 1, 2019
4 of 4 tasks complete
@afbora afbora self-assigned this Oct 1, 2019
afbora added a commit that referenced this issue Oct 2, 2019
bastianallgeier added a commit that referenced this issue Oct 2, 2019
bastianallgeier added a commit that referenced this issue Oct 2, 2019
@bastianallgeier

This comment has been minimized.

Copy link
Contributor

@bastianallgeier bastianallgeier commented Oct 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
You can’t perform that action at this time.