Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No options when using youtube() #2118

Closed
dorb4n opened this issue Sep 17, 2019 · 1 comment

Comments

@dorb4n
Copy link

@dorb4n dorb4n commented Sep 17, 2019

Describe the bug
I don't get the parameters in the youtube url (iframe) when setting the $options in the youtube() function.

https://getkirby.com/docs/reference/templates/helpers/youtube

To Reproduce
In my Template i use the youtube() function with the $options to hide the controlls:

youtube($myVideoUrl, array("controlls" => 0))

Expected behavior
I want to get an iframe with the parameter controlls, like:

<iframe allowfullscreen src="https://www.youtube.com/embed/123456789?controlls=0"></iframe>

But the ?controlls=0 is missing.

Kirby Version
3.2.4

Console output
No Output

Desktop (please complete the following information):

  • OS: macOS
  • Browser: Firefox
  • Version: 69

Additional context
https://github.com/getkirby/kirby/blob/3.2.4/src/Toolkit/Html.php#L439
Is $options['youtube'] right? With $options it works.

html::youtube() works perfectly.

bastianallgeier added a commit that referenced this issue Sep 26, 2019
@bastianallgeier bastianallgeier referenced this issue Sep 26, 2019
3 of 3 tasks complete
bastianallgeier added a commit that referenced this issue Sep 27, 2019
bastianallgeier added a commit that referenced this issue Sep 27, 2019
@bastianallgeier

This comment has been minimized.

Copy link
Contributor

@bastianallgeier bastianallgeier commented Sep 27, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
You can’t perform that action at this time.