Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Panel] Files pagination page label missing and need translation #2194

Closed
afbora opened this issue Oct 11, 2019 · 3 comments

Comments

@afbora
Copy link
Contributor

@afbora afbora commented Oct 11, 2019

FireShot Capture 776 - Animals - Mægazine_ - http___localhost_test_kirby_2192_p

Describe the bug

On files pagination, Page string doesn't change when switch the language because of non-translated string. I tried pageLabel option but didnt work.

sections:
    images:
        type: files
        layout: cards
        template: image
        info: "{{ file.dimensions }}"
        image:
          ratio: 5/4
          cover: true
        min: 1
        size: small
        limit: 3
        pageLabel: Sayfa

To Reproduce
Steps to reproduce the behavior:

  1. Go to panel
  2. Add above files section to page blueprint
  3. Click pagination of center
  4. See untranslated Page label

Related Lines:

https://github.com/getkirby/kirby/blob/develop/panel/src/components/Navigation/Pagination.vue#L94-L108

Expected behavior
I think pageLabel should be translated as default and may be implement pageLabel option and fixing should be effect all that using Pagination component

Kirby Version
3.2.5

@distantnative

This comment has been minimized.

Copy link
Contributor

@distantnative distantnative commented Oct 11, 2019

I would add a translation string pagination.page - don't think this needs to be a blueprint option.

@bastianallgeier

This comment has been minimized.

Copy link
Contributor

@bastianallgeier bastianallgeier commented Oct 11, 2019

Nope, a blueprint option is not needed. I don't think this ever needs to be customised once it's translated.

@distantnative distantnative added this to the 3.3.0 milestone Oct 11, 2019
@distantnative distantnative self-assigned this Oct 11, 2019
distantnative added a commit that referenced this issue Oct 11, 2019
@distantnative

This comment has been minimized.

Copy link
Contributor

@distantnative distantnative commented Oct 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.