Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Title attribute in required <abbr> tag should be translated #2227

Closed
texnixe opened this issue Oct 19, 2019 · 5 comments
Assignees
Milestone

Comments

@texnixe
Copy link
Contributor

@texnixe texnixe commented Oct 19, 2019

Currently, the title attribute is hard-coded:

<abbr v-if="required" title="This field is required">*</abbr>

in /kirby/panel/src/components/Forms/Field.vue

@distantnative distantnative added this to the 3.3.0 milestone Oct 19, 2019
@bastianallgeier bastianallgeier self-assigned this Oct 19, 2019
@bastianallgeier

This comment has been minimized.

Copy link
Contributor

@bastianallgeier bastianallgeier commented Oct 19, 2019

@distantnative before you start, I've already fixed it. PR is coming in a minute :)

@bastianallgeier

This comment has been minimized.

Copy link
Contributor

@bastianallgeier bastianallgeier commented Oct 19, 2019

Ok, I merged it immediately. The change is too small for a PR.

bastianallgeier added a commit that referenced this issue Oct 19, 2019
@bastianallgeier

This comment has been minimized.

Copy link
Contributor

@bastianallgeier bastianallgeier commented Oct 19, 2019

afbora added a commit that referenced this issue Oct 19, 2019
@afbora afbora referenced this issue Oct 19, 2019
0 of 4 tasks complete
bastianallgeier added a commit that referenced this issue Oct 21, 2019
@bastianallgeier

This comment has been minimized.

Copy link
Contributor

@bastianallgeier bastianallgeier commented Oct 21, 2019

@afbora thanks for solving this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
You can’t perform that action at this time.