Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Panel]: "Maximum call stack size exceeded." with empty Structure `fields` parameter #2236

Closed
neildaniels opened this issue Oct 21, 2019 · 1 comment

Comments

@neildaniels
Copy link
Contributor

@neildaniels neildaniels commented Oct 21, 2019

Describe the bug
If you specify a structure field with an empty fields parameter, the Panel will display a "Maximum call stack size exceeded." error when you try to add an item to the Structure.

To Reproduce
Steps to reproduce the behavior:

  1. Add a structure field to a Blueprint, but leave the fields property empty
recommendations:
  type: structure
  fields:
  1. Open the page in the Panel
  2. Click the "Add" button for the structure
  3. See error

Expected behavior
I would expect a more user-friendly error message saying that that the fields parameter is empty.

For example, if you completely omit the fields parameter, it gives a proper Blueprint error saying "Please provide a value for “fields”".

Screenshots
Screen Shot 2019-10-21 at 1 12 47 PM

Kirby Version
3.2.5

Console output

[Warning] RangeError: Maximum call stack size exceeded. — app.js:1:65982 (app.js, line 1)

Desktop (please complete the following information):

  • OS: macOS 10.15
  • Browser: Safari 13.0.2
  • Browser: Chrome 77.0.3865.120
@neildaniels neildaniels changed the title [Panel]: "Maximum call stack size exceeded." with Structure with Empty `fields` Parameter [Panel]: "Maximum call stack size exceeded." with empty Structure `fields` Parameter Oct 21, 2019
@neildaniels neildaniels changed the title [Panel]: "Maximum call stack size exceeded." with empty Structure `fields` Parameter [Panel]: "Maximum call stack size exceeded." with empty Structure `fields` parameter Oct 21, 2019
@lukasbestle lukasbestle added this to the 3.3.1 milestone Oct 21, 2019
@bastianallgeier bastianallgeier modified the milestones: 3.3.1, 3.3.0 Oct 23, 2019
bastianallgeier added a commit that referenced this issue Oct 23, 2019
@bastianallgeier

This comment has been minimized.

Copy link
Contributor

@bastianallgeier bastianallgeier commented Oct 23, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
You can’t perform that action at this time.