Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Panel] Toggle Text in Structure Get Squished Very Easily #2244

Closed
neildaniels opened this issue Oct 22, 2019 · 1 comment

Comments

@neildaniels
Copy link
Contributor

@neildaniels neildaniels commented Oct 22, 2019

Describe the bug
The new toggle field in a Structure field is super helpful, but the text seem kind of unnecessary/cluttered when viewed in the Structure overview.

Expected behavior
I'd be totally okay if the text part of the toggle was just completely omitted in the Structure field (or just showed the default on/off, which is much more compact). The label is displayed as the table header, and I suspect a majority of times that's sufficient.

Screenshots
Screen Shot 2019-10-22 at 3 23 41 PM

Kirby Version
3.3.0-rc.1

Desktop (please complete the following information):

  • OS: macOS 10.15
  • Browser: Safari
  • Version: 13.0.2
@bastianallgeier bastianallgeier added this to the 3.3.0 milestone Oct 23, 2019
@bastianallgeier bastianallgeier self-assigned this Oct 23, 2019
bastianallgeier added a commit that referenced this issue Oct 23, 2019
@bastianallgeier

This comment has been minimized.

Copy link
Contributor

@bastianallgeier bastianallgeier commented Oct 23, 2019

The toggle text is no longer wrapped now. You can also disable text entirely in the columns settings:

fields:
  structure:
    columns:
      a:
        text: false
      b:
        text: false
      c:
        text: false
      d:
        text: false
    fields:
      a:
        type: toggle
      b:
        type: toggle
        text: this is some long text
      c:
        type: toggle
      d:
        type: toggle
        text: this is some very very very long text
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.