Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.3.0RC1] Lock conflict on pages with unsaved changes #2245

Closed
nilshoerrmann opened this issue Oct 23, 2019 · 11 comments
Milestone

Comments

@nilshoerrmann
Copy link
Contributor

@nilshoerrmann nilshoerrmann commented Oct 23, 2019

Describe the bug
On a page with unsaved changes the panel throws three consecutive errors in the console. The save bar is disfunctional and doesn't react to clicks. Panel navigation still works.

To Reproduce
Steps to reproduce the behavior:

  1. Update to 3.3.0 RC 1.
  2. Go to a page with unsaved changes.

Expected behavior
No errors and a functional save bar.

Kirby Version
Kirby 3.3.0 RC 1.

Console output

{
	status: "error", 
	message: "An error occurred", 
	code: 501, 
	exception: "Kirby\\Exception\\Exception", 
	key: "error.lock.notImplemented", 
	file: "/hananils.2019/kirby/config/api/routes/lock.php", 
	line: 34, 
	details: [], 
	route: "(.*)/lock" 
}
{ 
	status: "error", 
	message: "An error occurred", 
	code: 501, 
	exception: "Kirby\\Exception\\Exception", 
	key: "error.lock.notImplemented", 
	file: "/hananils.2019/kirby/config/api/routes/lock.php", 
	line: 48, 
	details: [], 
	route: "(.*)/lock" 
}
uncaught exception: Object

Desktop (please complete the following information):
Firefox 70 on macOS Catalina.

Additional context
Content locking is disabled, this is a multilingual install. I'm not sure if this is a routing issue that might be connected to #2237 but for some reasons this does only happen on pages with changes.

Not sure if this is relevant but all changes stored in local storage were made before updating. The widget that displays pending changes globally doesn't display all changes stored in local storage.

@afbora

This comment has been minimized.

Copy link
Contributor

@afbora afbora commented Oct 23, 2019

I can't reproduced this issue with subfolder, multilang and content.locking enabled or disabled.

@nilshoerrmann

This comment has been minimized.

Copy link
Contributor Author

@nilshoerrmann nilshoerrmann commented Oct 23, 2019

Hm, not sure which info to provide for further debugging …

@distantnative

This comment has been minimized.

Copy link
Contributor

@distantnative distantnative commented Oct 23, 2019

Could you provide some more information on the page type? Just standard, one with a page model, virtual page?

@nilshoerrmann

This comment has been minimized.

Copy link
Contributor Author

@nilshoerrmann nilshoerrmann commented Oct 23, 2019

It's a standard page, one blueprint extending the other. Content coming from the content folder.

@distantnative distantnative added this to the 3.3.0 milestone Oct 23, 2019
@nilshoerrmann

This comment has been minimized.

Copy link
Contributor Author

@nilshoerrmann nilshoerrmann commented Oct 23, 2019

I'm just asking myself if this might have to do with the Editor field. I see that the object in local storage flags my text field as changed. There are no changes I know of. So I deleted the entry in local storage and reloaded the page. And the entry in local storage gets restored.

@distantnative

This comment has been minimized.

Copy link
Contributor

@distantnative distantnative commented Oct 23, 2019

The error messages you are getting should not be connected to that directly - the exception gets thrown when content locking is deactivated but should be caught and the Panel should react properly.

@nilshoerrmann

This comment has been minimized.

Copy link
Contributor Author

@nilshoerrmann nilshoerrmann commented Oct 23, 2019

I see, thanks.

@thathoff

This comment has been minimized.

Copy link

@thathoff thathoff commented Oct 23, 2019

I have seen a similar behaviour but also on v3.2.5. I’m not sure this is exactly the same problem because I did not manage to get the console logs but the described behaviour is exactly the same: You have unsaved changes but the Save button is greyed out and not clickable. After reloading the page everything is fine (thanks to local storage all changes are still there) and you can hit save again.

@afbora

This comment has been minimized.

Copy link
Contributor

@afbora afbora commented Oct 23, 2019

I can reproduce this issue when refresh the unsaved page 👍

image (3)

@afbora

This comment has been minimized.

Copy link
Contributor

@afbora afbora commented Oct 23, 2019

This error from /lock PATCH request before /lock GET request that get supported option. So system still thinks that the supported / content.locking option is enabled.

bastianallgeier added a commit that referenced this issue Oct 23, 2019
@bastianallgeier

This comment has been minimized.

Copy link
Contributor

@bastianallgeier bastianallgeier commented Oct 23, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
You can’t perform that action at this time.