Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error in console when a page with unsaved changes is deleted #2251

Closed
texnixe opened this issue Oct 26, 2019 · 6 comments

Comments

@texnixe
Copy link
Contributor

@texnixe texnixe commented Oct 26, 2019

Describe the bug
https://forum.getkirby.com/t/error-when-deleting-a-page-with-unsaved-changes/16079

To Reproduce
Steps to reproduce the behavior:

  1. Go to Panel.
  2. Make changes in a page without saving.
  3. Delete that page without saving changes
  4. See error

Expected behavior
No error should be thrown but the store emptied.

Kirby 3.0.0 rc-2

@bastianallgeier

This comment has been minimized.

Copy link
Contributor

@bastianallgeier bastianallgeier commented Oct 28, 2019

I cannot reproduce this in rc-2!

@bastianallgeier

This comment has been minimized.

Copy link
Contributor

@bastianallgeier bastianallgeier commented Oct 28, 2019

Neither in my local dev environment nor in the release download. This issue existed in rc-1. I'm pretty sure it's fixed in rc-2 already.

@afbora

This comment has been minimized.

Copy link
Contributor

@afbora afbora commented Oct 28, 2019

I have fresh test again, still reproduce the issue:

delete

@afbora afbora reopened this Oct 28, 2019
@bastianallgeier

This comment has been minimized.

Copy link
Contributor

@bastianallgeier bastianallgeier commented Oct 28, 2019

Ok, I'm stupid. I got content locking disabled in my local environment. Sorry! I will test this again.

bastianallgeier added a commit that referenced this issue Oct 28, 2019
@bastianallgeier

This comment has been minimized.

Copy link
Contributor

@bastianallgeier bastianallgeier commented Oct 28, 2019

Pretty sure I got it right this time :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.