Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Panel] Mailto link to null on email field #2254

Closed
afbora opened this issue Oct 28, 2019 · 1 comment

Comments

@afbora
Copy link
Contributor

@afbora afbora commented Oct 28, 2019

Describe the bug
You can click the email icon in the license registration window (this is all about the email field)
The link is also incorrect when there are empty or invalid emails.

To Reproduce
Steps to reproduce the behavior:

  1. Go to panel
  2. Click on Register top navbar
  3. Click on envelope/email icon
  4. See weird linking to null mail

Or

  1. Go to panel
  2. Edit any page/user that have empty email field
  3. Click on envelope/email icon
  4. See weird linking to null mail

Expected behavior

  1. It didn't make sense to link to mailto:null or own email address in this dialog.
  2. The link on the icon can be removed according to the usage.
  3. Only the link should be given when the email field is filled.

Screenshots
image

Kirby Version
3.2.5+

@bastianallgeier bastianallgeier added this to the 3.3.1 milestone Oct 30, 2019
afbora added a commit that referenced this issue Nov 7, 2019
@afbora afbora mentioned this issue Nov 7, 2019
0 of 4 tasks complete
@afbora afbora self-assigned this Nov 7, 2019
bastianallgeier added a commit that referenced this issue Nov 18, 2019
bastianallgeier added a commit that referenced this issue Nov 18, 2019
@bastianallgeier

This comment has been minimized.

Copy link
Contributor

@bastianallgeier bastianallgeier commented Nov 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.