Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clicking on the language in the Settings should open the edit dialog #2264

Closed
GiantCrocodile opened this issue Oct 31, 2019 · 3 comments
Closed

Comments

@GiantCrocodile
Copy link

@GiantCrocodile GiantCrocodile commented Oct 31, 2019

Describe the bug
Any other field is editable by clicking on it. Only the language in Settings is not editable on click. This should be changed to improve the usability by a more uniform system behavior. Right now, nothing happens if you click it. You have to use the three dots on the right side of the entry and choose edit.

To Reproduce
Steps to reproduce the behavior:

  1. Go to Settings
  2. Click on any language like the default language

Expected behavior
Clicking on the language opens the edit dialog.

Kirby Version
3.3.0 rc4

@afbora

This comment has been minimized.

Copy link
Contributor

@afbora afbora commented Nov 6, 2019

Collection ui kit <k-collection> wants to link property for each item to click.
However, since language editing is in the dialog, it needs to be done in a slightly different way 😇 For example manual listing items instead of using <k-collection> like following:

<k-list>
   <k-list-item></k-list-item>
   <k-list-item></k-list-item>
</k-list>
@GiantCrocodile

This comment has been minimized.

Copy link
Author

@GiantCrocodile GiantCrocodile commented Nov 6, 2019

Sounds like it is still an easy issue, although it has to be implemented a bit different :)? I'm glad that you dig through my issues and work on so many issues actively. Great work @afbora!

@bastianallgeier bastianallgeier modified the milestones: 3.3.1, 3.3.2 Nov 19, 2019
@distantnative distantnative self-assigned this Nov 23, 2019
distantnative added a commit that referenced this issue Nov 23, 2019
bastianallgeier added a commit that referenced this issue Nov 25, 2019
@bastianallgeier

This comment has been minimized.

Copy link
Contributor

@bastianallgeier bastianallgeier commented Nov 25, 2019

fixed on the develop branch. Will be in 3.3.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.