Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Page slugs are no longer created correctly #2282

Closed
texnixe opened this issue Nov 5, 2019 · 3 comments

Comments

@texnixe
Copy link
Contributor

@texnixe texnixe commented Nov 5, 2019

@afbora afbora added this to the 3.3.1 milestone Nov 6, 2019
@afbora

This comment has been minimized.

Copy link
Contributor

@afbora afbora commented Nov 6, 2019

I found the source of the issue.

Here's our escape pattern in helper:

/[\p{L}]|[-\/\\^$*+?.()|[\]{}]+/u

After rendering: /media/panel/xxx/app.js

/[Lp\{\}]|[\$\(-\+\x2D-\/\?\[-\^\{-\}]+/

https://github.com/getkirby/kirby/blob/master/panel/src/helpers/regex.js

When i update with original pattern in app.js, working properly. Any idea about rendering issue @bastianallgeier ?

@afbora

This comment has been minimized.

Copy link
Contributor

@afbora afbora commented Nov 6, 2019

Using the u flag single or with g (/gu), disrupts the pattern when rendering and removes the u flag 🤔

afbora added a commit that referenced this issue Nov 6, 2019
In the `replace` method, the `u` flag was not rendered properly, it was converted to the `new RegExp()` method with corrected pattern
@afbora afbora self-assigned this Nov 6, 2019
bastianallgeier added a commit that referenced this issue Nov 18, 2019
bastianallgeier added a commit that referenced this issue Nov 18, 2019
In the `replace` method, the `u` flag was not rendered properly, it was converted to the `new RegExp()` method with corrected pattern
bastianallgeier added a commit that referenced this issue Nov 18, 2019
@bastianallgeier

This comment has been minimized.

Copy link
Contributor

@bastianallgeier bastianallgeier commented Nov 18, 2019

bastianallgeier added a commit that referenced this issue Nov 26, 2019
In the `replace` method, the `u` flag was not rendered properly, it was converted to the `new RegExp()` method with corrected pattern
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
You can’t perform that action at this time.