Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't enter space in multiselect search field #2340

Closed
LeBenLeBen opened this issue Dec 6, 2019 · 5 comments
Closed

Can't enter space in multiselect search field #2340

LeBenLeBen opened this issue Dec 6, 2019 · 5 comments

Comments

@LeBenLeBen
Copy link

@LeBenLeBen LeBenLeBen commented Dec 6, 2019

Describe the bug
When I type in the search field of a "multiselect" and press the space bar, no space is inserted in the field.

My field blueprint looks like this:

      related:
        label: Related Articles
        type: multiselect
        search: true
        options: query
        query:
          fetch: page.siblings.filterBy("template", "article").published
          value: '{{ page.slug }}'
          text: '{{ page.title }}'

To Reproduce
Steps to reproduce the behavior:

  1. Edit a page having a multiselect field with search enabled in the panel
  2. Focus the field and start typing words
  3. Press the space bar
    -> No space is inserted

Expected behavior
The search should allow me to enter spaces to separate words.

Kirby Version
3.3.1

Console output
No errors

Desktop (please complete the following information):

  • OS: macOS
  • Browser: Firefox
  • Version: 71
@afbora

This comment has been minimized.

Copy link
Contributor

@afbora afbora commented Dec 6, 2019

@distantnative

This comment has been minimized.

Copy link
Contributor

@distantnative distantnative commented Dec 6, 2019

I am starting to hate keyboard support for the multiselect field :(

@afbora

This comment has been minimized.

Copy link
Contributor

@afbora afbora commented Dec 7, 2019

@distantnative As I remember, you did that PR to correct the focus with enter. But I don't think we need to prevent the space key. When I tried to remove that line, I saw that it worked without any problems. What do you think? 🤔

@distantnative

This comment has been minimized.

Copy link
Contributor

@distantnative distantnative commented Dec 7, 2019

@afbora Yes, I added it to make the multiselect field more work like a standard select field. It's complicated to make it work with such standards :(

bastianallgeier added a commit that referenced this issue Dec 9, 2019
@bastianallgeier

This comment has been minimized.

Copy link
Contributor

@bastianallgeier bastianallgeier commented Dec 9, 2019

It's more important to not break the input than to open the dialog on space.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
You can’t perform that action at this time.