Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Roles::load(): Only try to load files, skip directories #2383

Closed
lukasbestle opened this issue Jan 4, 2020 · 2 comments
Closed

Roles::load(): Only try to load files, skip directories #2383

lukasbestle opened this issue Jan 4, 2020 · 2 comments

Comments

@lukasbestle
Copy link
Contributor

@lukasbestle lukasbestle commented Jan 4, 2020

Describe the bug

If the site/blueprints/users directory contains a subdirectory (for some reason), Kirby will try to load that subdirectory as a role file.

To Reproduce
Steps to reproduce the behavior:

  1. Create a directory site/blueprints/users/.something
  2. Try to log in to the Panel
  3. Error Missing handler for type: "something"

Expected behavior

Kirby should check is_file() here:

https://github.com/getkirby/kirby/blob/3.3.2/src/Cms/Roles.php#L120

Kirby Version

3.3.2

@lukasbestle

This comment has been minimized.

bastianallgeier added a commit that referenced this issue Jan 7, 2020
@bastianallgeier

This comment has been minimized.

Copy link
Contributor

@bastianallgeier bastianallgeier commented Jan 7, 2020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.