Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalize `grayscale` thumb option #2384

Closed
texnixe opened this issue Jan 5, 2020 · 1 comment
Closed

Normalize `grayscale` thumb option #2384

texnixe opened this issue Jan 5, 2020 · 1 comment

Comments

@texnixe
Copy link
Contributor

@texnixe texnixe commented Jan 5, 2020

Currently, calling the thumb option with greyscale or bw fails.

Works:

echo $page->image()->thumb(['width' => 250, 'grayscale' => true]);

Doesn't work:

echo $page->image()->thumb(['width' => 250, 'greyscale' => true]);

Doesn't work either:

echo $page->image()->thumb(['width' => 250, 'bw' => true]);

However, there is a method bw, and in the filename grayscale() method, these option values are normalized.

It would probably make sense to allow using those alternatives in the thumbs options as well.

A screenshot from our own confusion in the docs (now fixed):

Bildschirmfoto 2020-01-05 um 13 07 44

@texnixe texnixe changed the title Normalize thumb options for `grayscale` Normalize `grayscale` thumb option Jan 5, 2020
@distantnative distantnative added this to the 3.3.3 milestone Jan 7, 2020
bastianallgeier added a commit that referenced this issue Jan 9, 2020
bastianallgeier added a commit that referenced this issue Jan 9, 2020
bastianallgeier added a commit that referenced this issue Jan 10, 2020
@bastianallgeier

This comment has been minimized.

Copy link
Contributor

@bastianallgeier bastianallgeier commented Jan 10, 2020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
You can’t perform that action at this time.