Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Language editor in the Panel: Empty locale not validated #2455

Closed
lukasbestle opened this issue Feb 15, 2020 · 1 comment
Closed

Language editor in the Panel: Empty locale not validated #2455

lukasbestle opened this issue Feb 15, 2020 · 1 comment
Assignees
Milestone

Comments

@lukasbestle
Copy link
Contributor

@lukasbestle lukasbestle commented Feb 15, 2020

Originally reported by @afbora in #2435:


Saving empty locale issue as a second problem steps to reproduce:

  1. Add a language
  2. Edit language
  3. Leave blank locale input
  4. Save language
  5. See issue as language config like:
'locale' => [
    'LC_ALL' => ''
]

You can also enter a space from panel and config saving like that:

'locale' => [
    'LC_ALL' => '    '
]

I think we should fix this by:

  • removing surrounding whitespace from the input by trimming
  • setting the locale to the language code if empty (like the Panel already does it when creating languages)
@afbora afbora self-assigned this Feb 17, 2020
@afbora afbora added this to the 3.3.5 milestone Feb 17, 2020
afbora added a commit that referenced this issue Feb 17, 2020
@afbora afbora mentioned this issue Feb 17, 2020
3 of 4 tasks complete
@afbora afbora linked a pull request that will close this issue Feb 17, 2020
3 of 4 tasks complete
afbora added a commit that referenced this issue Feb 20, 2020
bastianallgeier added a commit that referenced this issue Mar 5, 2020
@bastianallgeier

This comment has been minimized.

Copy link
Contributor

@bastianallgeier bastianallgeier commented Mar 5, 2020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked pull requests

Successfully merging a pull request may close this issue.

3 participants
You can’t perform that action at this time.