Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Panel] Add auto-save not only on blur, but every X seconds #268

Closed
distantnative opened this issue Mar 22, 2018 · 5 comments
Closed

[Panel] Add auto-save not only on blur, but every X seconds #268

distantnative opened this issue Mar 22, 2018 · 5 comments
Labels
type: enhancement ✨ Suggests an enhancement; improves Kirby
Milestone

Comments

@distantnative
Copy link
Member

No description provided.

@distantnative distantnative added the type: enhancement ✨ Suggests an enhancement; improves Kirby label Mar 22, 2018
@distantnative distantnative added this to the Alpha 7 milestone Mar 22, 2018
@jenstornell
Copy link

jenstornell commented Mar 23, 2018

Is the time counter reset on blur save? I hope so. There is no need to re-save on time directly after it has just been saved by the blur.

If you are going to reply, what is the time seconds set to? 30 seconds?

@distantnative
Copy link
Member Author

There is no time interval at all. You will hear more about it later in the live stream, but in Alpha 6 on every input the values are saved to localStorage and then with the hit of a button (or Cmd+S) send to the API. So we do not need any auto-save on blur or after X seconds anymore at the moment.

@jenstornell
Copy link

jenstornell commented Mar 23, 2018

Ahh, I see. I hope it's very clear in the panel when the page is saved and when it's not (when it's in localstorage).

Else we may forget to save the localstorage data to file. The next day we for some reason need to clear the cache, change browser or use the phone instead to continue to work. Then all the work will be lost, (not there) because it's bound to the computer and browser where we started the page.

I see a big risk, so I hope you get this right.

A really visible notice that the page is not saved is probably the best/only way. Maybe you have already solved it this way?

@distantnative
Copy link
Member Author

I'd suggest you check out the stream in less than four hours.

@jenstornell
Copy link

Alright, I'll hold my breath until then... Sorry for about the nag. 😸

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement ✨ Suggests an enhancement; improves Kirby
Projects
None yet
Development

No branches or pull requests

2 participants