Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve page redirection on languages detect #2484

Merged

Conversation

@afbora
Copy link
Contributor

afbora commented Mar 3, 2020

Describe the PR

When you access to a page with detected language and without language code:
example.com/contact

Redirecting Before PR:
example.com/en/contact

Redirecting After PR:
example.com/tr/iletisim

Use Case
You want to link to a page on your site from outside and be language independent.
Because the user entering the page expecting for the page to be opened in his own language.

You can link without language code, user will be redirecting to own language

Example Usage

<a href="http://example.com/an-article-about-kirby">You must read this article</a>

Will be redirecting safely to: example.com/tr/kirby-hakkinda-bir-makale

Related issues

Ready?

  • Added unit tests for fixed bug/feature
  • Passing all unit tests
  • Fixed code style issues with CS fixer and composer fix
  • Added in-code documentation (if needed)
@afbora afbora self-assigned this Mar 3, 2020
@afbora afbora marked this pull request as ready for review Mar 4, 2020
…-detection
@bastianallgeier bastianallgeier added this to the 3.3.5 milestone Mar 5, 2020
@bastianallgeier bastianallgeier merged commit c92187c into develop Mar 5, 2020
1 check failed
1 check failed
Travis CI - Branch Build Errored
Details
@bastianallgeier bastianallgeier deleted the feature/500-improve-page-redirection-lang-detection branch Mar 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.