Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cached auth user data on update #2487

Merged
merged 3 commits into from Mar 5, 2020

Conversation

afbora
Copy link
Member

@afbora afbora commented Mar 5, 2020

Describe the PR

Update cached auth user data on update only if the current user is this user.

@lukasbestle Could you help me about unit test? 馃槆 I'm getting error like following:

Kirby\Cms\UserActionsTest::testUpdateWithAuthUser
Exception: The directory "/dev/null" cannot be created

Related issues

Ready?

  • Added unit tests for fixed bug/feature
  • Passing all unit tests
  • Fixed code style issues with CS fixer and composer fix
  • Added in-code documentation (if needed)

@afbora afbora self-assigned this Mar 5, 2020
@afbora afbora linked an issue Mar 5, 2020 that may be closed by this pull request
@afbora
Copy link
Member Author

afbora commented Mar 5, 2020

I have fixed the unit test different way.
If there is a deficiency or an error in the test, we can fix it.

@bastianallgeier bastianallgeier merged commit c49f48a into develop Mar 5, 2020
@bastianallgeier bastianallgeier deleted the fix/2486-update-auth-user branch March 5, 2020 14:23
@afbora afbora added this to the 3.3.5 milestone Mar 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug 馃悰 Is a bug; fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

User.txt session refresh issue after $user->update
2 participants